• Skip to sidebar navigation
  • Skip to content

Bitbucket

  • More
    ProjectsRepositories
  • Help
    • Online help
    • Learn Git
    • Welcome to Bitbucket
    • Keyboard shortcuts
  • Log In
Alexander Dahl
  1. Alexander Dahl

buildroot

Public
Actions
  • Clone
  • Compare

Learn more about cloning repositories

You have read-only access

Navigation
  • Source
  • Commits
  • Branches
  • All Branches Graph
  • Forks
  1. Alexander Dahl
  2. buildroot

Source

buildroot/package/audiofile/0001-Fix-pkg-config-for-static-linking.patch
Jörg KrauseJörg Krause committed 1a0645851cf24 Nov 2015
Raw file
Source viewDiff to previous
xxxxxxxxxx
 
1
From 2abf7d2e5c533bf4d7407c2c8057a329cd49a3cd Mon Sep 17 00:00:00 2001
2
From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks>
3
Date: Tue, 24 Nov 2015 21:57:27 +0100
4
Subject: [PATCH 1/1] Fix pkg-config for static linking
5
MIME-Version: 1.0
6
Content-Type: text/plain; charset=UTF-8
7
Content-Transfer-Encoding: 8bit
8
​
9
Static linking userspace programs such as MPD against libaudiofile fails if
10
FLAC is available, because libaudiofile is linked against FLAC, but this isn't
11
expressed in the pkg-config file:
12
​
13
[..]
14
arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libaudiofile.a(FLAC.o): In function `FLACDecoder::reset2()':
15
FLAC.cpp:(.text+0x58): undefined reference to `FLAC__stream_decoder_seek_absolute'
16
/home/buildroot/build/instance-1/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libaudiofile.a(FLAC.o): In function `FLACEncoder::sync2()':
17
FLAC.cpp:(.text+0x88): undefined reference to `FLAC__stream_encoder_finish'
18
/home/buildroot/build/instance-1/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libaudiofile.a(FLAC.o): In function `FLACDecoder::~FLACDecoder()':
19
FLAC.cpp:(.text+0xc4): undefined reference to `FLAC__stream_decoder_delete'
20
/home/buildroot/build/instance-1/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libaudiofile.a(FLAC.o): In function `FLACEncoder::~FLACEncoder()':
21
FLAC.cpp:(.text+0x164): undefined reference to `FLAC__stream_encoder_delete'
22
/home/buildroot/build/instance-1/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libaudiofile.a(FLAC.o): In function `FLACDecoder::runPull()':
23
[..]
24
​
25
The Libs.private field is specifically designed for such usage:
26
​
27
From pkg-config documentation:
28
​
29
  Libs.private:
30
​
31
     This line should list any private libraries in use.  Private
32
     libraries are libraries which are not exposed through your
33
     library, but are needed in the case of static linking.
34
​
35
Therefore, this patch adds a reference to FLAC as well as to lcov in the
36
Libs.private field of the pkg-config file.
37
​
38
Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
39
---
40
 audiofile.pc.in | 2 +-
41
 1 file changed, 1 insertion(+), 1 deletion(-)
42
​
43
diff --git a/audiofile.pc.in b/audiofile.pc.in
44
index ad5956a..d6055ef 100644
45
--- a/audiofile.pc.in
46
+++ b/audiofile.pc.in
47
@@ -8,5 +8,5 @@ Description: audiofile
48
 Requires:
49
 Version: @VERSION@
50
 Libs: -L${libdir} -laudiofile
51
-Libs.private: -lm
52
+Libs.private: @FLAC_LIBS@ @COVERAGE_LIBS@ -lm
53
 Cflags: -I${includedir}
54
-- 
55
2.6.2
56
​
  • Git repository management for enterprise teams powered by Atlassian Bitbucket
  • Atlassian Bitbucket v6.7.2
  • Documentation
  • Request a feature
  • About
  • Contact Atlassian
Atlassian

Everything looks good. We'll let you know here if there's anything you should know about.