• Skip to sidebar navigation
  • Skip to content

Bitbucket

  • More
    ProjectsRepositories
  • Help
    • Online help
    • Learn Git
    • Welcome to Bitbucket
    • Keyboard shortcuts
  • Log In
Alexander Dahl
  1. Alexander Dahl

buildroot

Public
Actions
  • Clone
  • Compare

Learn more about cloning repositories

You have read-only access

Navigation
  • Source
  • Commits
  • Branches
  • All Branches Graph
  • Forks
  1. Alexander Dahl
  2. buildroot

Source

buildroot/package/libhid/libhid-dont-fiddle-with-debug-flags.patch
Thomas PetazzoniThomas Petazzoni committed d813f70741112 Dec 2012
Raw file
Source viewDiff to previous
xxxxxxxxxx
 
1
Don't do horrible magic with CFLAGS and CXXFLAGS
2
​
3
The purpose of the lines being removed is to suppress the
4
-g<something> option from the CFLAGS or CXXFLAGS, when --enable-debug
5
is not used. This is stupid because it is up to the user to pass these
6
flags or not.
7
​
8
But it is not only stupid, but utterly broken: if your CFLAGS contains
9
a flags like -mfloat-gprs=double, then this option gets truncated to
10
-mfloat simply because the option contained the -g string!
11
​
12
Completely ridiculous piece of code, so get rid of it.
13
​
14
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
15
​
16
Index: libhid-0.2.16/m4/md_conf_debugging.m4
17
===================================================================
18
--- libhid-0.2.16.orig/m4/md_conf_debugging.m4  2004-11-08 18:16:25.000000000 +0100
19
+++ libhid-0.2.16/m4/md_conf_debugging.m4   2012-12-12 20:24:50.000000000 +0100
20
@@ -1,7 +1,7 @@
21
 AC_DEFUN([MD_CONF_DEBUGGING],
22
   [
23
-    CFLAGS=$(echo $CFLAGS | sed -e 's,-g[[^[:space:]]]*,,g')
24
-    CXXFLAGS=$(echo $CXXFLAGS | sed -e 's,-g[[^[:space:]]]*,,g')
25
+#    CFLAGS=$(echo $CFLAGS | sed -e 's,-g[[^[:space:]]]*,,g')
26
+#    CXXFLAGS=$(echo $CXXFLAGS | sed -e 's,-g[[^[:space:]]]*,,g')
27
     MD_CHECK_ARG_ENABLE(debug,
28
       [
29
         DEBUG_FLAG=-g
  • Git repository management for enterprise teams powered by Atlassian Bitbucket
  • Atlassian Bitbucket v6.7.2
  • Documentation
  • Request a feature
  • About
  • Contact Atlassian
Atlassian

Everything looks good. We'll let you know here if there's anything you should know about.