• Skip to sidebar navigation
  • Skip to content

Bitbucket

  • More
    ProjectsRepositories
  • Help
    • Online help
    • Learn Git
    • Welcome to Bitbucket
    • Keyboard shortcuts
  • Log In
Alexander Dahl
  1. Alexander Dahl

buildroot

Public
Actions
  • Clone
  • Compare

Learn more about cloning repositories

You have read-only access

Navigation
  • Source
  • Commits
  • Branches
  • All Branches Graph
  • Forks
  1. Alexander Dahl
  2. buildroot

Source

buildroot/package/libssh2/0001-drop-custom-buildconf-script.patch
Sam VossSam Voss committed a660d1fc74431 Oct 2017
Raw file
Source viewDiff to previous
 
1
From 39a2a444a32896bd2dab37c9b247ccfd11ff4693 Mon Sep 17 00:00:00 2001
2
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
3
Date: Mon, 30 Oct 2017 19:29:12 +0100
4
Subject: [PATCH] buildsystem: drop custom buildconf script, rely on autoreconf
5
​
6
The buildconf script is currently required, because we need to copy a
7
header around, because it is used both from the library and the examples
8
sources.
9
​
10
However, having a custom 'buildconf'-like script is not needed if we can
11
ensure that the header / exists by the time it is needed. For That, we
12
can just append the src/ directory to the headers search path for the
13
examples.
14
​
15
And then it means we no longer need to generate the same header twice,
16
so we remove the second one from configure.ac.
17
​
18
Now, we can just call "autoreconf -fi" to generate the autotools files,
19
instead of relying on the canned sequence in "buildconf", since
20
autoreconf has now long known what to do at the correct moment (future
21
versions of autotools, automake, autopoint, autoheader etc... may
22
require an other ordering, or other intermediate steps, etc...).
23
​
24
Eventually, get rid of buildconf now it is no longer needed. In fact, we
25
really keep it for legacy, but have it just call autoreconf (and print a
26
nice user-friendly warning).
27
​
28
Update gitignore accordingly, too.
29
​
30
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
31
Cc: Sam Voss <sam.voss@rockwellcollins.com>
32
---
33
 .gitignore          |  2 ++
34
 buildconf           | 24 +++++-------------------
35
 configure.ac        |  2 +-
36
 example/.gitignore  |  2 --
37
 example/Makefile.am |  2 +-
38
 5 files changed, 9 insertions(+), 23 deletions(-)
39
​
40
diff --git a/.gitignore b/.gitignore
41
index 997e51e1..b6d6b5cb 100644
42
--- a/.gitignore
43
+++ b/.gitignore
44
@@ -13,6 +13,8 @@ Makefile
45
 Makefile.in
46
 aclocal.m4
47
 autom4te.cache
48
+compile
49
+test-driver
50
 config.guess
51
 config.log
52
 config.status
53
diff --git a/buildconf b/buildconf
54
index 558dcb66..728b3397 100755
55
--- a/buildconf
56
+++ b/buildconf
57
@@ -1,22 +1,8 @@
58
 #!/bin/sh
59
 
60
-LIBTOOLIZE="libtoolize"
61
+echo "***" >&2
62
+echo "*** Do not use buildconf. Instead, just use: autoreconf -fi" >&2
63
+echo "*** Doing it for you now, but buildconf may disapear in the future." >&2
  • Git repository management for enterprise teams powered by Atlassian Bitbucket
  • Atlassian Bitbucket v6.7.2
  • Documentation
  • Request a feature
  • About
  • Contact Atlassian
Atlassian

Everything looks good. We'll let you know here if there's anything you should know about.