• Skip to sidebar navigation
  • Skip to content

Bitbucket

  • More
    ProjectsRepositories
  • Help
    • Online help
    • Learn Git
    • Welcome to Bitbucket
    • Keyboard shortcuts
  • Log In
Alexander Dahl
  1. Alexander Dahl

buildroot

Public
Actions
  • Clone
  • Compare

Learn more about cloning repositories

You have read-only access

Navigation
  • Source
  • Commits
  • Branches
  • All Branches Graph
  • Forks
  1. Alexander Dahl
  2. buildroot

Source

buildroot/package/lldpd/0002-configure-do-not-check-for-libbsd.patch
Yann E. MORINYann E. MORIN committed f5716ac760818 Aug 2016
Raw file
Source viewDiff to previous
xxxxxxxxxx
 
1
From 0801a066cd4a24a858ddfa7c62c7802e0f5533a8 Mon Sep 17 00:00:00 2001
2
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
3
Date: Sun, 14 Aug 2016 12:15:17 +0200
4
Subject: [PATCH] configure: do not check for libbsd
5
​
6
libbsd causes build issues because its libbsd-overlay.pc file is borked:
7
it contains -isystem in CFLAGS, which is not munged by pkgconf, so we
8
end up using the headers of the build machine, causing all sorts of
9
hard-to-debug trouble at build time.
10
​
11
lldpd uses libbsd-overlay for a few helper functions, but has fallbacks
12
in case it is not available. The only feature that is lost when not using
13
it is that the neighbour name is no longer displayed in /proc/self/cmdline.
14
As the author of lldpd said on IRC: "people should survive! ;-)"
15
​
16
So we just remove the detection of libbsd altogether.
17
​
18
Fixes:
19
    http://autobuild.buildroot.org/results/6b7/6b70fa379e834ec71cc260ba6af771b531ca3511/
20
    http://autobuild.buildroot.org/results/769/769074c4bb67336ae6679f2c1cd2a8220d2bec24/
21
    http://autobuild.buildroot.org/results/c8a/c8a6001f437701ecc75f6c9252935645bda8a8c8/
22
    [...]
23
​
24
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
25
---
26
 configure.ac | 19 -------------------
27
 1 file changed, 19 deletions(-)
28
​
29
diff --git a/configure.ac b/configure.ac
30
index dd723b0..45498ce 100644
31
--- a/configure.ac
32
+++ b/configure.ac
33
@@ -165,25 +165,6 @@ AC_FUNC_MALLOC
34
 AC_FUNC_REALLOC
35
 AC_FUNC_FORK
36
 
37
-# Some functions can be in libbsd
38
-PKG_CHECK_MODULES([libbsd], [libbsd-overlay], [
39
-  _save_CFLAGS="$CFLAGS"
40
-  _save_LIBS="$LIBS"
41
-  CFLAGS="$CFLAGS $libbsd_CFLAGS"
42
-  LIBS="$LIBS $libbsd_LIBS"
43
-  AC_MSG_CHECKING([if libbsd can be linked correctly])
44
-  AC_LINK_IFELSE([AC_LANG_SOURCE([[int main() { return 0; }]])],
45
-    [
46
-      AC_MSG_RESULT(yes)
47
-      LLDP_CFLAGS="$LLDP_CFLAGS $libbsd_CFLAGS"
48
-      LLDP_LDFLAGS="$LLDP_LDFLAGS $libbsd_LIBS"
49
-    ],[
50
-      AC_MSG_RESULT(no)
51
-      CFLAGS="$_save_CFLAGS"
52
-      LIBS="$_save_LIBS"
53
-    ])
54
-], [:])
55
-
56
 # setproctitle may have an _init function
57
 AC_REPLACE_FUNCS([setproctitle])
58
 AC_CHECK_FUNCS([setproctitle_init])
59
-- 
60
2.7.4
61
​
  • Git repository management for enterprise teams powered by Atlassian Bitbucket
  • Atlassian Bitbucket v6.7.2
  • Documentation
  • Request a feature
  • About
  • Contact Atlassian
Atlassian

Everything looks good. We'll let you know here if there's anything you should know about.